Add cross platform support for Windows #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robdel12
commented
Mar 13, 2019
run-tests.js
Outdated
| : `cypress`; | ||
|
|
||
| const server = httpServer.createServer() | ||
| const PORT = 8000 |
anaulin
reviewed
Mar 14, 2019
package.json
Outdated
| @@ -10,6 +10,7 @@ | |||
| "devDependencies": { | |||
| "@percy/cypress": "^1.0.2", | |||
| "cypress": "^3.1.5", | |||
| "http-server": "^0.11.1" | |||
| "http-server": "^0.11.1", | |||
| "https-server": "^0.1.2" | |||
There was a problem hiding this comment.
Do you ever use this https-server package? Might not be needed.
There was a problem hiding this comment.
Very good catch! I did not intend to add that 😱
anaulin
approved these changes
Mar 14, 2019
There was a problem hiding this comment.
This change looks 👍 to me.
Happy to see this merged as soon as the various CI builds go green. Looks like the Percy build failed for some reason -- I triggered another CI workflow run to see if that goes better. It would be good to look into why it failed the first time around.
|
All builds are 💚 now, so feel free to merge as soon as you remove that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
This adds support for running the example app from windows. I have verified this works with windows with this specific build coming from my windows machine: https://percy.io/percy/example-percy-cypress/builds/1564784